Skip to content

[Security Vulnerability] Fix for Insecure deserialization vulnerability in checkpoint loader#75

Open
hayageek wants to merge 3 commits intogoogle:mainfrom
hayageek:main
Open

[Security Vulnerability] Fix for Insecure deserialization vulnerability in checkpoint loader#75
hayageek wants to merge 3 commits intogoogle:mainfrom
hayageek:main

Conversation

@hayageek
Copy link
Copy Markdown

@hayageek hayageek commented Mar 9, 2026

Fixes for: #74

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 9, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical security enhancement to the checkpoint loading mechanism. By implementing a restricted deserialization process, it mitigates an insecure deserialization vulnerability (CWE-502) that could otherwise allow arbitrary code execution when processing untrusted metadata files. This change significantly improves the robustness and security of the system against malicious payloads.

Highlights

  • Security Fix: Addressed an insecure deserialization vulnerability (CWE-502) in the checkpoint loader to prevent arbitrary code execution from untrusted .metadata files.
  • Restricted Deserialization: Implemented a custom _RestrictedMetadataUnpickler that uses an explicit allowlist of PyTorch checkpoint metadata classes and types, ensuring only safe objects can be deserialized.
  • Code Update: Replaced the direct use of pickle.load() with the new _RestrictedMetadataUnpickler in the read_metadata function to enforce secure deserialization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/ml_flashpoint/core/checkpoint_loader.py
    • Defined _SAFE_METADATA_UNPICKLE_ALLOWLIST to specify allowed modules and names for safe deserialization.
    • Created _RestrictedMetadataUnpickler, a subclass of pickle.Unpickler, which overrides find_class to enforce the allowlist.
    • Modified the read_metadata function to utilize _RestrictedMetadataUnpickler instead of the standard pickle.load() for secure metadata loading.
Activity
  • The pull request was opened by hayageek to address a security vulnerability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to address a critical insecure deserialization vulnerability by replacing the unsafe pickle.load() with a custom _RestrictedMetadataUnpickler. While this is a good step, the same vulnerability persists in the read_tensor function, which still uses pickle.loads on untrusted data, creating a significant security gap for arbitrary code execution. Additionally, the current implementation lacks a dedicated unit test to verify the security fix for read_metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hayageek